GUACAMOLE-1290: Migrate SSH certificate auth support to new memory management functions. #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mike-jumper CI Build is still failing - not sure if it needs a re-base to get it working correctly? |
|
Yep, needs a rebase. Just a moment... |
…nagement functions.
mike-jumper
force-pushed
the
update-ssh-cert-auth
branch
from
e7c1deb
to
4c467d5
Compare
|
OK - hopefully that does the trick. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the only code specific to
masterthat still pointed at good ol'free()andstrdup()following the merge of #462, thankfully all relevant to the same JIRA issue (GUACAMOLE-1290).Outside of this, the only other old code that remains using
free(),malloc(), etc. is code that deals with memory allocated or freed by a third-party library.