Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUACAMOLE-1658: Remove reference to non-existing ssh_key header. #467

Draft
wants to merge 2 commits into
base: staging/1.6.0
Choose a base branch
from
Draft

GUACAMOLE-1658: Remove reference to non-existing ssh_key header. #467

wants to merge 2 commits into from

Conversation

necouchman
Copy link
Contributor

Removes the reference to the non-existent ssh_key.h file, which breaks when you try to build with SSH agent support (--enable-ssh-agent).

Submitting this is a bug fix to 1.5.4.

@necouchman necouchman marked this pull request as draft November 1, 2023 11:16
@necouchman
Copy link
Contributor Author

Converting to a draft for the moment - this needs a bit more work to fix the other issues that are present because of it.

@mike-jumper mike-jumper deleted the branch apache:staging/1.6.0 December 8, 2023 00:56
@mike-jumper mike-jumper closed this Dec 8, 2023
@mike-jumper mike-jumper reopened this Dec 8, 2023
@mike-jumper mike-jumper changed the base branch from staging/1.5.4 to staging/1.5.5 December 8, 2023 03:51
@jmuehlner
Copy link
Contributor

Are there still issues with this PR? It looks pretty straightforward, and the issue appears to be still valid as well.

@necouchman
Copy link
Contributor Author

@jmuehlner Yeah, unfortunately this is going to require re-implementing the overall SSH agent/key support that got removed. There are notes in the Jira issue - https://issues.apache.org/jira/browse/GUACAMOLE-1658.

@mike-jumper mike-jumper deleted the branch apache:staging/1.6.0 April 5, 2024 17:36
@mike-jumper mike-jumper closed this Apr 5, 2024
@mike-jumper mike-jumper reopened this Apr 7, 2024
@mike-jumper mike-jumper changed the base branch from staging/1.5.5 to patch April 7, 2024 06:27
@necouchman necouchman mentioned this pull request Apr 12, 2024
Draft
@necouchman necouchman changed the base branch from patch to main June 4, 2024 23:36
@Yugnk
Copy link

Yugnk commented Jul 26, 2024

I can't ssh with priv key. When I put the priv key in Guacamole. It doesn't connect. It gives the error "Log in failed. Please reconnect and try again."

@necouchman
Copy link
Contributor Author

@Yugnk This is not the place to ask that question - this is a (draft) pull request, not a mailing list or support forum.

@mike-jumper mike-jumper changed the base branch from main to staging/1.6.0 August 1, 2024 21:07
@DenisVerkhovsky
Copy link

Hi,
Is there any update regarding the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@necouchman @jmuehlner @Yugnk @DenisVerkhovsky @mike-jumper