Skip to content

GUACAMOLE-1658: Remove reference to non-existing ssh_key header.#467

Draft
necouchman wants to merge 2 commits intoapache:patchfrom
necouchman:jira/1658
Draft

GUACAMOLE-1658: Remove reference to non-existing ssh_key header.#467
necouchman wants to merge 2 commits intoapache:patchfrom
necouchman:jira/1658

Conversation

@necouchman
Copy link
Copy Markdown
Contributor

Removes the reference to the non-existent ssh_key.h file, which breaks when you try to build with SSH agent support (--enable-ssh-agent).

Submitting this is a bug fix to 1.5.4.

@necouchman necouchman marked this pull request as draft November 1, 2023 11:16
@necouchman
Copy link
Copy Markdown
Contributor Author

Converting to a draft for the moment - this needs a bit more work to fix the other issues that are present because of it.

@mike-jumper mike-jumper deleted the branch apache:patch December 8, 2023 00:56
@mike-jumper mike-jumper closed this Dec 8, 2023
@mike-jumper mike-jumper reopened this Dec 8, 2023
@mike-jumper mike-jumper changed the base branch from staging/1.5.4 to staging/1.5.5 December 8, 2023 03:51
@jmuehlner
Copy link
Copy Markdown
Contributor

Are there still issues with this PR? It looks pretty straightforward, and the issue appears to be still valid as well.

@necouchman
Copy link
Copy Markdown
Contributor Author

@jmuehlner Yeah, unfortunately this is going to require re-implementing the overall SSH agent/key support that got removed. There are notes in the Jira issue - https://issues.apache.org/jira/browse/GUACAMOLE-1658.

@mike-jumper mike-jumper deleted the branch apache:patch April 5, 2024 17:36
@mike-jumper mike-jumper closed this Apr 5, 2024
@mike-jumper mike-jumper reopened this Apr 7, 2024
@mike-jumper mike-jumper changed the base branch from staging/1.5.5 to patch April 7, 2024 06:27
@necouchman necouchman changed the base branch from patch to main June 4, 2024 23:36
@Yugnk
Copy link
Copy Markdown

Yugnk commented Jul 26, 2024

I can't ssh with priv key. When I put the priv key in Guacamole. It doesn't connect. It gives the error "Log in failed. Please reconnect and try again."

@necouchman
Copy link
Copy Markdown
Contributor Author

@Yugnk This is not the place to ask that question - this is a (draft) pull request, not a mailing list or support forum.

@mike-jumper mike-jumper changed the base branch from main to staging/1.6.0 August 1, 2024 21:07
@DenisVerkhovsky
Copy link
Copy Markdown

Hi,
Is there any update regarding the fix?

@mike-jumper mike-jumper deleted the branch apache:patch June 23, 2025 01:16
@mike-jumper
Copy link
Copy Markdown
Contributor

Sorry @necouchman - looks like this and apache/guacamole-client#971 got auto-closed when I deleted the staging branch for 1.6.0 at release time.

@mike-jumper mike-jumper reopened this Sep 22, 2025
@mike-jumper mike-jumper changed the base branch from staging/1.6.0 to patch September 22, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants