GUACAMOLE-1140: Address RDP pipe svc race condition. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation of RDPGFX.
…ive processing lag.
…st one frame boundary has been received.
…mentation is resized when desktop is resized.
…args" for readability.
…end_sync(). The new guac_protocol_send_sync() requires an additional parameter: the number of logical frames associated with the sync.
…ocol_send_sync().
…don't support it.
… lack the key entirely.
…th batch join API.
…ity with batch join API.
…nagement functions.
…w memory management functions.
Those will be made nodiscard at some point anyway.
|
Looks like this branch wasn't rebased against |
|
Well, that somehow got completely messed up. Closing this PR to re-open against staging/1.5.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address the race condition associated with the RDP client join handler and the pipe svc attempt to access the
available_svcmember of therdp_clientdata structure. I've taken both suggestions in one of the Jira tickets for 1) acquiring the overall lock and 2) doing aNULLcheck aroundavailable_svcbefore attempting to access it.It's worth noting that simply acquiring the lock on its own within the
guac_rdp_join_pending_handler()function does not actually resolve the problem - theNULLcheck is required. So, I'm not sure in the lock is actually worth anything, or if there's somewhere else (around the SFTP connection, maybe?) that the lock should also be acquired?