GUACAMOLE-1231: Implement basic support for restoring minimized RAIL windows #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I rather like this. It immediately mitigates the issue at hand without requiring huge changes, but also doesn't get in the way of some future representation for minimized windows. |
jmuehlner
reviewed
May 23, 2024
jmuehlner
reviewed
May 23, 2024
jmuehlner
reviewed
May 24, 2024
jmuehlner
reviewed
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really basic update for the Guacamole RAIL channel that handles situations where RAIL windows are minimized by simply immediately sending the
SC_RESTOREcommand for that window back to the RDP server, causing the window to immediately re-appear. This resolves, at a very basic level, the issue with RAIL windows that are minimized becoming inaccessible within the Guacamole interface.Looking at both the MS-RDPERP specification and the xfreerdp client, I suspect there is a lot more potential for some really cool functionality within the RAIL channel that could be implemented within Guacamole - like the ability to track what RAIL windows are open for a particular client, perhaps even open them in new/separate windows, and perhaps even integrate with the current multi-connection support to provide an icon representation of "minimized" RAIL windows. But, I thought I'd go the simpler route, first, and just solve the problem of not being able to access things that get [mistakenly] minimized.