GUACAMOLE-1910: Add locking around TLS socket #482
Conversation
When TLS is turned on the file descriptor for the socket does not use locking when writing to it. It results in corrupted guacamole instructions being written to the stream when there are multiple connected clients. This adds a mutex in the same manner done in `socket-fd.c`.
Okay I think I rebased it properly. Please take a look. I pulled There were no conflicts (I did not expect any based on the changes to guacamole-server), so maybe there was an easier way to do this. |
|
Do you prefer bringing up issues in the mailing list prior to filing an issue on jira and submitting a pull request? |
|
When the issue is something that may be configuration-related and not actually a bug, we definitely prefer mailing list first. For something like this where it's clear that we're missing a lock, it makes sense to just open up the JIRA issue directly. |
When TLS is turned on the file descriptor for the socket does not use locking when writing to it. It results in corrupted guacamole instructions being written to the stream when there are multiple connected clients.
This adds a mutex in the same manner done in
socket-fd.c.