Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-925: Patch add russian keyboard #507

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NickVStepin
Copy link

No description provided.

Add Russian keyboard support for RDP
Add Russian keyboard keymap support for RDP
Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NickVStepin! A couple of minor updates requested, here, and one thing that I'd like Mike's feedback on.

Also, the title of the Pull Request, as well as the commit message(s) should contain the GUACAMOLE-925: prefix - see the other PRs for examples of that.

src/protocols/rdp/Makefile.am Outdated Show resolved Hide resolved
src/protocols/rdp/keymaps/ru_ru_qwerty.keymap Show resolved Hide resolved
@NickVStepin NickVStepin changed the title Patch add russian keyboard GUACAMOLE-925: Patch add russian keyboard Apr 16, 2024
@necouchman
Copy link
Contributor

@NickVStepin I see you updated pull request title, but commit messages also need to be 1) updated to include "GUACAMOLE-925:" prefix, and 2) should be descriptive of the changes.

@NickVStepin
Copy link
Author

Thanks @NickVStepin! A couple of minor updates requested, here, and one thing that I'd like Mike's feedback on.

Also, the title of the Pull Request, as well as the commit message(s) should contain the GUACAMOLE-925: prefix - see the other PRs for examples of that.

Thanks @necouchman.
Sorry, i don't change prefix my commit messages. :(
Should I create new commit messages?

@necouchman
Copy link
Contributor

@NickVStepin : You can do the following:

  • Use "git log" to find the commit ID of the commit before your first commit.
  • Use "git rebase -i " to start an interactive rebase.
  • Use the "reword" option on each of the commits.
  • Change the commit messages.
  • Force-push the changes, which will automatically update this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants