GUACAMOLE-1944: Remove display margin on mouse position #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
reviewed
Apr 16, 2024
|
This looks fine to me, unless @mike-jumper or @jmuehlner have any concerns. However, @corentin-soriano, you have two commit messages with identical contents - might be best to squash them together, or, if you think you need both of them, improve the messages so that they are useful in describing what the commits are doing. |
corentin-soriano
force-pushed
the
GUACAMOLE-1944_mouse_position_offset
branch
from
3e3a182
to
825d87f
Compare
No particular use for having multiple commit messages. I squashed them. |
necouchman
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove display->margin on mouse position to avoid offset between selection and actual mouse position.