-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUACAMOLE-1633: Add support of alternate screen buffer #521
GUACAMOLE-1633: Add support of alternate screen buffer #521
Conversation
This is some how related to GUACAMOLE-1256? |
This pull request is not related to this ticket. |
I was wondering if this alternate screen buffer would also solve that other problem, but thank you for clarifying |
29c8d30
to
da5d866
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change, other than that looks okay to me.
Only other question is - does it make sense to allocate the alternate buffer only if/when it's required? I'm good either way, just curious...
da5d866
to
2ad3a7c
Compare
Indeed, it helps to limit memory usage. I made the modification, no impact on performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
Add support of alternate screen buffer for tools like less/vi/man/...
Before:
After: