Skip to content

GUACAMOLE-1633: Add support of alternate screen buffer#521

Merged
necouchman merged 1 commit intoapache:mainfrom
corentin-soriano:GUACAMOLE-1633_alternate_buffer
Jun 11, 2024
Merged

GUACAMOLE-1633: Add support of alternate screen buffer#521
necouchman merged 1 commit intoapache:mainfrom
corentin-soriano:GUACAMOLE-1633_alternate_buffer

Conversation

@corentin-soriano
Copy link
Copy Markdown
Member

@corentin-soriano corentin-soriano commented Jun 5, 2024

Add support of alternate screen buffer for tools like less/vi/man/...

Before:
image

After:
image
image
image

necouchman
necouchman reviewed Jun 5, 2024
View reviewed changes
Comment thread src/terminal/terminal-handlers.c Outdated
@hugaleno
Copy link
Copy Markdown

hugaleno commented Jun 5, 2024

This is some how related to GUACAMOLE-1256?

@corentin-soriano
Copy link
Copy Markdown
Member Author

corentin-soriano commented Jun 5, 2024

This is some how related to GUACAMOLE-1256?

This pull request is not related to this ticket.

This PR only avoid this display on editor close:
image

@hugaleno
Copy link
Copy Markdown

hugaleno commented Jun 5, 2024

I was wondering if this alternate screen buffer would also solve that other problem, but thank you for clarifying

@corentin-soriano corentin-soriano force-pushed the GUACAMOLE-1633_alternate_buffer branch 2 times, most recently from 29c8d30 to da5d866 Compare June 5, 2024 14:56
necouchman
necouchman requested changes Jun 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, other than that looks okay to me.

Only other question is - does it make sense to allocate the alternate buffer only if/when it's required? I'm good either way, just curious...

Comment thread src/terminal/terminal/terminal-priv.h
@corentin-soriano corentin-soriano force-pushed the GUACAMOLE-1633_alternate_buffer branch from da5d866 to 2ad3a7c Compare June 11, 2024 07:37
@corentin-soriano
Copy link
Copy Markdown
Member Author

corentin-soriano commented Jun 11, 2024

One change, other than that looks okay to me.

Only other question is - does it make sense to allocate the alternate buffer only if/when it's required? I'm good either way, just curious...

Indeed, it helps to limit memory usage. I made the modification, no impact on performance.
I took the opportunity to declare it without scrollback since it's unnecessary on the alternate buffer.

necouchman
necouchman approved these changes Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@necouchman necouchman merged commit aa6e7ad into apache:main Jun 11, 2024
@necouchman necouchman mentioned this pull request Jun 11, 2024
Closed
@corentin-soriano corentin-soriano deleted the GUACAMOLE-1633_alternate_buffer branch May 30, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@necouchman necouchman necouchman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corentin-soriano @hugaleno @necouchman