Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1969: Implement recording-include-clipboard connection parameter #530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukasraska
Copy link

This PR introduces new recording-include-clipboard into all supported protocols that dumps the clipboard instruction, along with the relevant stream blobs, into recording.

Few key notes:

  • because clipboard can contain sensitive data, it's opt-in in the same way as recording-include-keys and administrators need to explicitly set the parameter to true
  • as the recording components are responsible for handling the recording dumps, guac_recording_create includes the new parameter (i've opted for making it the last argument, but let me know if I should switch it to be next to the include_keys)
  • the keyboard dumps are hooked into user clipboard handler, so should only handle changes from user side and not from the server side
  • as clipboard instruction merely creates stream, even the simplest paste is essentially at least 3 instructions (clipboard, 1+ blobs, end), which can be seen like this in some testing recording
$ sed 's/;/\n/g' recording-clipboard | grep clipboard -A 2
9.clipboard,1.0,10.text/plain
4.blob,1.0,20.UHVsbCBjb21wbGV0ZQ==
3.end,1.0

Once this PR is approved from technical perspective, I will create respective PRs for guacamole-client and guacamole-manual to accomodate for both documentation change as well the client side option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant