Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1026: Correct and clean up FreeRDP presence/absence reporting by configure. #540

Merged

Conversation

mike-jumper
Copy link
Contributor

Previously, the name of the library would change depending on which version is installed:

$ ./configure
...
------------------------------------------------
guacamole-server version 1.5.5
------------------------------------------------

   Library status:

     freerdp3 ............ yes
     pango ............... yes
     libavcodec .......... yes
...

and there was no output for the "disabled" case:

...
------------------------------------------------
guacamole-server version 1.5.5
------------------------------------------------

   Library status:

     freerdp ............ 
     pango ............... yes
     libavcodec .......... yes
...

Here, the library name remains constant while version notes are included to the side:

$ ./configure
...
------------------------------------------------
guacamole-server version 1.5.5
------------------------------------------------

   Library status:

     freerdp ............. yes (3.x)
     pango ............... yes
     libavcodec .......... yes
...

and the output of "disabled" is restored:

$ ./configure --without-rdp
...
------------------------------------------------
guacamole-server version 1.5.5
------------------------------------------------

   Library status:

     freerdp ............. disabled 
     pango ............... yes
     libavcodec .......... yes
...

…ng by configure.

Previously, the name of the library would change and there was no output
for the "disabled" case. Here, the library name remains constant while
version notes are included to the side, and the output of "disabled" is
restored.
@jmuehlner jmuehlner merged commit 3029b4c into apache:staging/1.6.0 Aug 28, 2024
1 check passed
@mike-jumper mike-jumper deleted the fix-freerdp3-check-output branch August 28, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants