GUACAMOLE-1196: Resize guacamole display only when VNC screen size is changed by the server. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-jumper
requested changes
Sep 6, 2024
… changed by the server.
jmuehlner
force-pushed
the
vnc-resize-fix-followup
branch
from
48c9c07
to
9fef551
Compare
mike-jumper
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, I was immediately resizing the guac display size right after sending the resize request to the server. This works fine as long as the VNC server actually does the resize as requested, but we can't assume that it will.
This change updates it to only update the display size when the screen size has changed.