Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1990: Add keymap for Canadian Multilingual Standard (CMS) layout #558

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tejaswikandula
Copy link
Contributor

No description provided.

@necouchman
Copy link
Contributor

@Tejaswikandula: Please correct the Pull Request title - it should be in the same format as the commit messages (GUACAMOLE-1990: Add Canadian...).

Also, you have two commits with the same commit message - the commit messages should be helpful and descriptive, and possibly squashed together.

@Tejaswikandula Tejaswikandula changed the title Guacamole 1990 Add Canadian Multilingual Standard (cms) layout to RDP Guacamole 1990 Add keymap for Canadian Multilingual Standard (CMS) layout Oct 30, 2024
@Tejaswikandula
Copy link
Contributor Author

@Tejaswikandula: Please correct the Pull Request title - it should be in the same format as the commit messages (GUACAMOLE-1990: Add Canadian...).

Also, you have two commits with the same commit message - the commit messages should be helpful and descriptive, and possibly squashed together.

I have fixed the title

@Tejaswikandula
Copy link
Contributor Author

On the Canadian Multilingual Standard Keyboard, the "Right-CTRL" key serves a distinct function from the "Left-CTRL" key, as it's used in combination with other keys to generate special characters. This is different from other layouts currently supported by guacamole. I noticed that the +ctrl modifier doesn’t seem to be supported. Adding this support would require modifying generate.pl to handle the +ctrl modifier, along with other changes and updates to existing keymap files. Could this be the recommended approach, or are there alternative methods to achieve this? I’d appreciate any insights. Thank you!

@necouchman necouchman changed the title Guacamole 1990 Add keymap for Canadian Multilingual Standard (CMS) layout GUACAMOLE-1990: Add keymap for Canadian Multilingual Standard (CMS) layout Oct 30, 2024
@Tejaswikandula
Copy link
Contributor Author

Tejaswikandula commented Oct 31, 2024

On the Canadian Multilingual Standard Keyboard, the "Right-CTRL" key serves a distinct function from the "Left-CTRL" key, as it's used in combination with other keys to generate special characters. This is different from other layouts currently supported by guacamole. I noticed that the +ctrl modifier doesn’t seem to be supported. Adding this support would require modifying generate.pl to handle the +ctrl modifier, along with other changes and updates to existing keymap files. Could this be the recommended approach, or are there alternative methods to achieve this? I’d appreciate any insights. Thank you!

@necouchman @mike-jumper Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants