GUACAMOLE-1167: Add server settings for RD gateway type. #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuehlner
reviewed
Oct 18, 2024
| @@ -1263,6 +1271,20 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user, | |||
| settings->gateway_port = | |||
| guac_user_parse_args_int(user, GUAC_RDP_CLIENT_ARGS, argv, | |||
| IDX_GATEWAY_PORT, 443); | |||
|
|
|||
| char* gateway_type = guac_user_parse_args_string(user, GUAC_RDP_CLIENT_ARGS, | |||
There was a problem hiding this comment.
What happens if this isn't set to any of these values?
There was a problem hiding this comment.
To be more clear, it'd be nice if there was some documentation somewhere in here that briefly explains what happens in the default case where the gateway-type parameter isn't set (or is set to some invalid value).
Comment on lines
+1991
to
+2004
| rdp_settings->GatewayHttpTransport = TRUE; | ||
| rdp_settings->GatewayRpcTransport = TRUE; | ||
| break; | ||
|
|
||
| /* Gateway is forced to HTTP, so only enable HTTP transport. */ | ||
| case GUAC_RDP_GATEWAY_HTTP: | ||
| rdp_settings->GatewayHttpTransport = TRUE; | ||
| rdp_settings->GatewayRpcTransport = FALSE; | ||
| break; | ||
|
|
||
| /* Gateway is forced to RPC, so only enable RPC transport. */ | ||
| case GUAC_RDP_GATEWAY_RPC: | ||
| rdp_settings->GatewayHttpTransport = FALSE; | ||
| rdp_settings->GatewayRpcTransport = TRUE; |
There was a problem hiding this comment.
I think we should add a block in the freerdp3 part (HAVE_SETTERS_GETTERS):
freerdp_settings_set_bool(rdp_settings, FreeRDP_GatewayHttpTransport, TRUE)
freerdp_settings_set_bool(rdp_settings, FreeRDP_GatewayRpcTransport, TRUE)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.