GUACAMOLE-1997: Fix issue on screen resize with freerdp >= 3.8.0.#563
Merged
mike-jumper merged 1 commit intoapache:staging/1.6.0from Nov 9, 2024
Conversation
Contributor
I'm a little concerned about that fix in FreeRDP/FreeRDP#10488. Triggering an I'll read through the surrounding code on our end a bit deeper, but my main concern is that this change in behavior could cause a race condition in the handling of "Display Update" vs. GDI updates. |
mike-jumper
requested changes
Nov 4, 2024
7791c23 to
11ea330
Compare
mike-jumper
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With freerdp >= 3.8.0, we can't resize with "display-update":
Caused by this bugfix in freerdp: FreeRDP/FreeRDP#10488
Freerdp triggers EndPaint first when resizing to ensure there are no unfinished BeginPaints.