GUACAMOLE-1256: Fix a display issue when scrolling up in vi as well as latency in less.#565
Merged
mike-jumper merged 1 commit intoapache:staging/1.6.0from Dec 18, 2024
Conversation
corentin-soriano
force-pushed
the
GUACAMOLE-1256_scroll_display_issue
branch
2 times, most recently
from
b7848db to
08aae5b
Compare
corentin-soriano
force-pushed
the
GUACAMOLE-1256_scroll_display_issue
branch
from
08aae5b to
c6517eb
Compare
…s latency in less.
corentin-soriano
force-pushed
the
GUACAMOLE-1256_scroll_display_issue
branch
from
c6517eb to
9bde8b9
Compare
Contributor
|
Looks okay to me. @mike-jumper or @jmuehlner, any thoughts/comments? |
Contributor
|
This looks at least equivalent to the workaround that was already put in place, and with the understanding that the workaround does appear to address the behavior, I'm happy with the change. More broadly, I'm not sure about the logic of the workaround. If the issue is that the terminal's |
mike-jumper
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows better synchronization between the buffer and the display, which avoids "mixed" displayed data when highlighting braces, parentheses and others in vi.
Seems to fix a latency issue when scrolling up in less.