[WIP] HIVE-29206: Remove commons-lang from hive-exec shaded jar #6079

KiranVelumuri · 2025-09-17T05:14:30Z

What changes were proposed in this pull request?

HIVE-29206

Why are the changes needed?

To completely remove commons-lang

Does this PR introduce any user-facing change?

No

How was this patch tested?

jar -tvf

github-actions · 2025-09-17T05:16:21Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (6)

calcualtion
Chrono
getenv
ntz
OOM
unsign

Previously acknowledged words that are now absent

www

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:KiranVelumuri/hive.git repository
on the HIVE-29206 branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/apache/hive/issues/comments/3301338633" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

If the flagged items do not appear to be text

If items relate to a ...

well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.
binary file.

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

zabetak

To be sure we don't have/use commons-lang in the project we should add an enforcer rule.

github-actions · 2025-09-17T12:43:28Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (6)

calcualtion
Chrono
getenv
ntz
OOM
unsign

Previously acknowledged words that are now absent

www

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:KiranVelumuri/hive.git repository
on the HIVE-29206 branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/apache/hive/issues/comments/3302813599" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

If the flagged items do not appear to be text

If items relate to a ...

well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.
binary file.

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

KiranVelumuri · 2025-09-17T12:45:56Z

To be sure we don't have/use commons-lang in the project we should add an enforcer rule.

Added the enforcer rule. We already have a check-banned-imports in place for commons-lang. We do not have commons-lang anywhere in the project dependency tree and would not allow from now on.

deniskuzZ · 2025-09-17T13:55:27Z

itests/hive-unit/pom.xml

            </goals>
            <configuration>
              <rules>
+                <bannedDependencies>


why don't we reuse the root pom declarations?

there's only junit-jupiter declared here which is different from those in root pom.

deniskuzZ · 2025-09-17T13:56:18Z

standalone-metastore/metastore-common/pom.xml

                    <exclude>com.google.code.findbugs:annotations</exclude>
                  </excludes>
                </bannedDependencies>
+                <bannedDependencies>


can we define this in root metastore pom.xml?

@KiranVelumuri , please check #6054, I have handled the same in the PR but as its not merged, please sync the banned dependencies in parent pom and standalone-metastore pom. I discovered that commons-logging was still getting shipped. So, IMO, its better to same set of banned dependencies across project.

I defined enforcer-plugin in root metastore pom.xml for now. Yes, I too feel that it's better to maintain the same set across parent pom and metastore pom.

github-actions · 2025-09-18T07:02:07Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (6)

calcualtion
Chrono
getenv
ntz
OOM
unsign

Previously acknowledged words that are now absent

www

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:KiranVelumuri/hive.git repository
on the HIVE-29206 branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/apache/hive/issues/comments/3305707952" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

If the flagged items do not appear to be text

If items relate to a ...

well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.
binary file.

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

sonarqubecloud · 2025-09-22T23:57:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

asf-ci-hive added the tests pending label Sep 17, 2025

asf-ci-hive added tests passed and removed tests pending labels Sep 17, 2025

zabetak reviewed Sep 17, 2025

View reviewed changes

KiranVelumuri force-pushed the HIVE-29206 branch from 366a6a8 to 77c52aa Compare September 17, 2025 12:41

asf-ci-hive added tests pending and removed tests passed labels Sep 17, 2025

asf-ci-hive added tests failed and removed tests pending labels Sep 17, 2025

deniskuzZ reviewed Sep 17, 2025

View reviewed changes

KiranVelumuri force-pushed the HIVE-29206 branch from 77c52aa to 2ffbf90 Compare September 18, 2025 07:00

asf-ci-hive added tests pending and removed tests failed labels Sep 18, 2025

asf-ci-hive added tests failed and removed tests pending labels Sep 18, 2025

KiranVelumuri force-pushed the HIVE-29206 branch from 2ffbf90 to 36384a7 Compare September 22, 2025 09:32

asf-ci-hive added tests pending tests failed and removed tests failed tests pending labels Sep 22, 2025

KiranVelumuri force-pushed the HIVE-29206 branch from 36384a7 to e8256f9 Compare September 22, 2025 16:15

asf-ci-hive added tests pending and removed tests failed labels Sep 22, 2025

HIVE-29206: Remove commons-lang from hive-exec shaded jar

6054b16

KiranVelumuri force-pushed the HIVE-29206 branch from e8256f9 to 6054b16 Compare September 22, 2025 17:00

asf-ci-hive added tests unstable tests pending and removed tests pending tests unstable labels Sep 22, 2025

asf-ci-hive added tests unstable and removed tests pending labels Sep 23, 2025

KiranVelumuri changed the title ~~HIVE-29206: Remove commons-lang from hive-exec shaded jar~~ [WIP] HIVE-29206: Remove commons-lang from hive-exec shaded jar Sep 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] HIVE-29206: Remove commons-lang from hive-exec shaded jar #6079

[WIP] HIVE-29206: Remove commons-lang from hive-exec shaded jar #6079

KiranVelumuri commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

zabetak left a comment

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

KiranVelumuri commented Sep 17, 2025

Uh oh!

deniskuzZ Sep 17, 2025 •

edited

Loading

Uh oh!

KiranVelumuri Sep 18, 2025

Uh oh!

deniskuzZ Sep 17, 2025

Uh oh!

Aggarwal-Raghav Sep 18, 2025

Uh oh!

KiranVelumuri Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Sep 22, 2025

Uh oh!

Uh oh!

[WIP] HIVE-29206: Remove commons-lang from hive-exec shaded jar #6079

Are you sure you want to change the base?

[WIP] HIVE-29206: Remove commons-lang from hive-exec shaded jar #6079

Conversation

KiranVelumuri commented Sep 17, 2025

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@check-spelling-bot Report

🔴 Please review

Unrecognized words (6)

Uh oh!

zabetak left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@check-spelling-bot Report

🔴 Please review

Unrecognized words (6)

Uh oh!

KiranVelumuri commented Sep 17, 2025

Uh oh!

deniskuzZ Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KiranVelumuri Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

deniskuzZ Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Aggarwal-Raghav Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

KiranVelumuri Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@check-spelling-bot Report

🔴 Please review

Unrecognized words (6)

Uh oh!

sonarqubecloud bot commented Sep 22, 2025

Quality Gate passed

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 17, 2025 •

edited

Loading

deniskuzZ Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 18, 2025 •

edited

Loading