-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-29031: Setup Derby database in qtests via qt:database option #6113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Add Derby support in QTestDatabaseHandler and implement proper setup and cleaup logic 2. Refactor docker instructions in separate class and update class hierarchy 3. Update all .q files using 'jdbc:derby' URLs to exploit the new functionality 4. Re-enable previously disabled tests since flakiness is resolved. 5. Rework dataconnector.q test exploiting the init script functionality and drop all Derby binary files.
|
A clean flaky run with all jdbc related tests can also be found here: https://ci.hive.apache.org/job/hive-flaky-check/904/ |
LGTM +1 (non-binding) |
Thanks for reviewing @saihemanth-cloudera ! All the files that you highlighted are setting the JDBC URL for the metastore. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Many thanks for the reviews @Aggarwal-Raghav and @saihemanth-cloudera ! |
What changes were proposed in this pull request?
Why are the changes needed?
dataconnector.q
)Does this PR introduce any user-facing change?
No
How was this patch tested?