HIVE-29251: Hive ACID: HiveConf object shouldn't be shared between multiple cleanup tasks #6119
+157
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
…ltiple cleanup tasks
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
deniskuzZ
commented
Oct 8, 2025
| // increase the size of the configuration or the number of failed compactions. | ||
| Assert.assertTrue("Allocated memory, " + diffMem + "bytes , exceeds acceptable variance of 250MB.", | ||
| diffMem < 250_000_000); | ||
| diffMem < 450_000_000); |
There was a problem hiding this comment.
increase because of thread-local use in a cleaner task thread
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use thread-local HiveConf objects
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
locally with multiple threads