Skip to content

Conversation

zhangbutao
Copy link
Contributor

@zhangbutao zhangbutao commented Oct 9, 2025

What changes were proposed in this pull request?

This PR adds a properties attribute to the catalog, which allows the creation and modification of catalog properties. This PR can serve for the upcoming Federated Catalog, as we will use properties to define the catalog type and pass custom property for each catalog.

// create catalog with properties
CREATE CATALOG test_cat  LOCATION '/tmp/test_cat' COMMENT 'Hive test catalog' PROPERTIES('key2'='value1');

// alter catalog properties
ALTER CATALOG test_cat set PROPERTIES ('key2'='value1');

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile='catalog.q' -Dtest.output.overwrite=true -pl itests/qtest -Pitests

And local Hive cluster test.

@deniskuzZ
Copy link
Member

why that many thrift gen changes?

@zhangbutao
Copy link
Contributor Author

why that many thrift gen changes?

@deniskuzZ Yes. Every modification to hive_metastore.thrift will result in changes to many gen files. For example, HIVE-28975. I believe this is the normal behavior of the Thrift tool. I am using Thrift version 0.16.0 locally and regenerated the code with the command:
mvn clean package -Pthriftif -Dthrift.home=/usr/local -DskipTests -pl standalone-metastore/metastore-common.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants