HIVE-29296: Remove getPrimaryKeys codes from beeline module #6157
Conversation
| if (row.isMeta) { | ||
| v = beeLine.getColorBuffer().center(row.values[i], row.sizes[i]); | ||
| if (beeLine.getOpts().getColor() && rows.isPrimaryKeyCol(i)) { | ||
| buf.cyan(v.getMono()); |
There was a problem hiding this comment.
Retrieving the primary key in Beeline is just for coloring the output. Removing this code blocks is safe.
|
|
why not simply revert JIRA that introduced PK fetching? |
The code for PK in Beeline was introduced during the implementation of HS2, rather than being implemented through a separate JIRA. See 96083e7 |
|
According to my memory, removing this part of the code means the coloring output only means that the header has different font type than the result set data. |
As I mentioned, this part of the code relates to the primary key and has never taken effect in Hive beeline, so I'm not very clear about the color or font of its output display.
Regarding whether to remove the entire coloring functionality code, I'm not entirely sure if there are real-world users who actually use the color option. However, through a Google search for the keyword |
4 participants
What changes were proposed in this pull request?
Why are the changes needed?
Please see HIVE-29213 & and HIVE-29296 to check the details.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Local Beeline test.