Skip to content

Commit

Permalink
mod_crypto: Fix warnings about signed bit fields.
Browse files Browse the repository at this point in the history
The non-zero value for one bit field is -1:

mod_crypto.c|565 col 18| error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
||     ctx->encrypt = 1;
||                  ^ ~
mod_crypto.c|746 col 22| error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
||         ctx->clength = 1;
||                      ^ ~
mod_crypto.c|903 col 35| error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
||                     ctx->seen_eos = 1;
||                                   ^ ~
mod_crypto.c|960 col 22| error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
||         ctx->clength = 1;
||                      ^ ~

Use unsigned bit fields for struct crypto_ctx's members seen_eos, encrypt and clength.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1916299 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
ylavic committed Mar 14, 2024
1 parent fb3dbd7 commit 9ef9e5a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions modules/filters/mod_crypto.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@ typedef struct crypto_ctx
apr_off_t remaining;
apr_off_t written;
apr_size_t osize;
int seen_eos:1;
int encrypt:1;
int clength:1;
unsigned int seen_eos :1,
encrypt :1,
clength :1;
} crypto_ctx;

static const char *parse_pass_conf_binary(cmd_parms *cmd,
Expand Down

0 comments on commit 9ef9e5a

Please sign in to comment.