[HUDI-8685] Re-enabling flaky/buggy test (TestHoodieBackedTableMetadata.testCleaningArchivingAndCompaction) #12656
+59
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokeshj1703
reviewed
Jan 21, 2025
There was a problem hiding this comment.
@nsivabalan Thanks for working on this! The CI is failing, can you please take a look?
| public void testCleaningArchivingAndCompaction() throws Exception { | ||
| init(HoodieTableType.COPY_ON_WRITE, false); | ||
| HoodieSparkEngineContext engineContext = new HoodieSparkEngineContext(jsc); | ||
|
|
||
| final int maxDeltaCommitsBeforeCompaction = 3; | ||
| final int maxDeltaCommitsBeforeCompaction = 5; |
There was a problem hiding this comment.
NIT: Rename to maxDeltaCommitsBeforeCompactionInMDT
| @@ -2509,13 +2509,14 @@ public void testReader() throws Exception { | |||
| * <p> | |||
| * Metadata Table should be automatically compacted as per config. | |||
| */ | |||
| @Disabled | |||
| @Test | |||
| public void testCleaningArchivingAndCompaction() throws Exception { | |||
There was a problem hiding this comment.
Should we reduce the complexity of the test or break it into separate tests?
Probably clustering related behaviour can be verified in a separate test.
| FileCreateUtils.createInflightCommit(basePath, newCommitTime); | ||
| inflightCommitTime = newCommitTime; | ||
| totalExpectedDeltaCommitsinMdt += 1; | ||
| if (i == 2) { |
There was a problem hiding this comment.
Would this only happen at i == 2 or also in subsequent iterations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Re-enabling flaky/buggy test (TestHoodieBackedTableMetadata.testCleaningArchivingAndCompaction)
Impact
Re-enabling flaky/buggy test (TestHoodieBackedTableMetadata.testCleaningArchivingAndCompaction)
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist