[HUDI-8881] trigger failure earlier in Flink Hudi sink #12666
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuangZhenQiu
changed the title
HuangZhenQiu
force-pushed
the
HUDI-8881-failure-handling
branch
from
6194d60 to
d04b0f1
Compare
HuangZhenQiu
force-pushed
the
HUDI-8881-failure-handling
branch
4 times, most recently
from
2d91da4 to
5333ece
Compare
cshuo
reviewed
Jan 21, 2025
...datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java
Outdated
Show resolved
Hide resolved
sharath1709
reviewed
Jan 22, 2025
| @@ -473,6 +475,19 @@ private void handleEndInputEvent(WriteMetadataEvent event) { | |||
| } | |||
| } | |||
|
|
|||
| private void filterWriteFailure(WriteMetadataEvent event) throws HoodieException { | |||
There was a problem hiding this comment.
Can we reuse the same logic in doCommit method as well to prevent any future logical divergence in detecting write failures?
There was a problem hiding this comment.
It is a good suggestion. The logical of detecting write failures is actually one single line with stream API. I feel it is overkill to create a separate function for it.
There was a problem hiding this comment.
@danny0405 Do you think we also need to log error in single event as commit time?
HuangZhenQiu
force-pushed
the
HUDI-8881-failure-handling
branch
from
5333ece to
3112505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Trigger failure when write failure is detected for flink hudi sink
Impact
The early detection of write failure will prevent checkpoint to complete before hudi commit. Thus, prevent the data loss when checkpoint is completed, but hudi can't committed due the write failure.
Risk level (write none, low medium or high below)
none
Documentation Update
It is an improvement of existing functionality, no user facing feature is introduced.
Contributor's checklist