[HUDI-8680] Enabling partition stats by default #12671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
force-pushed
the
enablePSIDefault
branch
from
5f059e9 to
e244110
Compare
nsivabalan
changed the title
nsivabalan
force-pushed
the
enablePSIDefault
branch
from
897dc9a to
5d0e60b
Compare
codope
reviewed
Jan 23, 2025
...di-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestMetadataTableSupport.java
Show resolved
Hide resolved
| {"c1_maxValue":959,"c1_minValue":74,"c1_nullCount":0,"c2_maxValue":" 959sdc","c2_minValue":" 181sdc","c2_nullCount":0,"c3_maxValue":980.213,"c3_minValue":38.740,"c3_nullCount":0,"c4_maxValue":"2021-11-19T20:40:55.550-08:00","c4_minValue":"2021-11-19T20:40:55.507-08:00","c4_nullCount":0,"c5_maxValue":97,"c5_minValue":9,"c5_nullCount":0,"c6_maxValue":"2020-11-22","c6_minValue":"2020-01-23","c6_nullCount":0,"c7_maxValue":"vw==","c7_minValue":"1A==","c7_nullCount":0,"c8_maxValue":9,"c8_minValue":9,"c8_nullCount":0,"valueCount":13} |
There was a problem hiding this comment.
Can we create followups for binary types as we discussed?
There was a problem hiding this comment.
HUDI-8909. I have left a comment in ColumnStatIndexTestBase L72
...atasource/hudi-spark/src/test/scala/org/apache/hudi/functional/ColumnStatIndexTestBase.scala
Outdated
Show resolved
Hide resolved
...atasource/hudi-spark/src/test/scala/org/apache/hudi/functional/ColumnStatIndexTestBase.scala
Outdated
Show resolved
Hide resolved
...atasource/hudi-spark/src/test/scala/org/apache/hudi/functional/ColumnStatIndexTestBase.scala
Outdated
Show resolved
Hide resolved
...atasource/hudi-spark/src/test/scala/org/apache/hudi/functional/ColumnStatIndexTestBase.scala
Outdated
Show resolved
Hide resolved
...atasource/hudi-spark/src/test/scala/org/apache/hudi/functional/ColumnStatIndexTestBase.scala
Show resolved
Hide resolved
|
@codope : Addressed all of your feedback |
codope
approved these changes
Jan 24, 2025
nsivabalan
force-pushed
the
enablePSIDefault
branch
from
6b0f6bf to
5b4d2d9
Compare
codope
force-pushed
the
enablePSIDefault
branch
from
5b4d2d9 to
b484c79
Compare
fixes after rebase Fixing rebasing merge conflicts fix post rebase
codope
force-pushed
the
enablePSIDefault
branch
from
b484c79 to
85b64d5
Compare
4 tasks
|
Closing in favor of #12707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Enabling partition stats by default for the spark engine.
Impact
Enabling partition stats by default for the spark engine.
Risk level (write none, low medium or high below)
medium
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist