[HUDI-8616] DataHub meta sync improvements (#12456) #12678
+942
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sgomezvillamor
commented
Jan 20, 2025
Comment on lines
+100
to
+101
| //.map(HoodieInstant::requestedTime); | ||
| .map(HoodieInstant::getTimestamp); |
There was a problem hiding this comment.
@xushiyan, requestedTime is how this was implemented in master. However, there isn't such a method in branch-0.x for HoodieInstant. Is getTimestamp a valid alternative?
sgomezvillamor
commented
Jan 20, 2025
| protected Option<String> getLastCommitCompletionTime() { | ||
| // int countInstants = getActiveTimeline().countInstants(); | ||
| // return getActiveTimeline() | ||
| // .getInstantsOrderedByCompletionTime() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Applies PR #12456 on top of branch-0.x branch.
And supersedes PR #12565
Impact
From PR #12456
Risk level (write none, low medium or high below)
Low, as per PR #12456
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist