[HUDI-8004] avoid unnecessary record rewrite during merging with base file #12683
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshuo
changed the title
|
@hudi-bot run azure |
danny0405
reviewed
Jan 22, 2025
| return isProjectionOfInternal(sourceSchema, targetSchema, AvroSchemaUtils::isAtomicTypeStrictProject); | ||
| } | ||
|
|
||
| private static boolean isAtomicTypeStrictProject(Schema source, Schema target) { |
|
@cshuo Can you take care the Azure CI failures? |
The azure CI failed due to timeout, there is a JIRA tracking the problem, https://issues.apache.org/jira/browse/HUDI-8893. |
|
@hudi-bot run azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
AvroSchemaUtils#isStrictProjectionOf, as it always return false when there exists decimal type field in the source schema.Impact
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist