-
Notifications
You must be signed in to change notification settings - Fork 2.4k
refactor: Update conversion from StructType to Avro Schema to include docs and default values #17473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
the-other-tim-brown
merged 8 commits into
apache:master
from
the-other-tim-brown:schema-doc-simplification
Dec 4, 2025
Merged
refactor: Update conversion from StructType to Avro Schema to include docs and default values #17473
the-other-tim-brown
merged 8 commits into
apache:master
from
the-other-tim-brown:schema-doc-simplification
Dec 4, 2025
+50
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
approved these changes
Dec 3, 2025
Contributor
yihua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nsivabalan
reviewed
Dec 3, 2025
...datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala
Show resolved
Hide resolved
Contributor
|
In Spark 3.5 + Scala 2.13, the test failed because of mismatched |
Collaborator
the-other-tim-brown
added a commit
to the-other-tim-brown/hudi
that referenced
this pull request
Dec 5, 2025
… docs and default values (apache#17473) * move docs and default values to schema construction * update test, make variables more readable, fix null ordering * make doc check for null or empty * try printing ddl * try logging ddl * fix logging * ensure table names are unique across tests to generate unique schemas * preserve h prefix for ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Currently there are two methods that developers must call to ensure that a StructType is properly converted to an Avro. This is error prone and can be simplified by unifying the code.
Summary and Changelog
Impact
Simplifies the code and eliminates risk of developers forgetting to call method to add doc strings or null values to the schema
Risk Level
None
Documentation Update
Contributor's checklist