Skip to content

test(server-test): enable run single unit test #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imbajin merged 3 commits into from
Jan 29, 2026
Merged

test(server-test): enable run single unit test #2940

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d0922b
test(server-test): enable run single unit test
JisoLya Jan 20, 2026
5c6269d
fix: thread-safe graph() method
JisoLya Jan 27, 2026
7b306b6
fix: more clear error handling in graph() method
JisoLya Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/core/CoreTestSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import org.apache.hugegraph.testutil.Utils;
import org.apache.hugegraph.util.Log;
import org.junit.AfterClass;
import org.junit.Assert;
Comment thread
JisoLya marked this conversation as resolved.
import org.junit.BeforeClass;
import org.junit.runner.RunWith;
import org.junit.runners.Suite;
Expand All @@ -52,11 +51,18 @@
public class CoreTestSuite {

private static boolean registered = false;
Comment thread
imbajin marked this conversation as resolved.
private static HugeGraph graph = null;
private static volatile HugeGraph graph = null;
Comment thread
JisoLya marked this conversation as resolved.

Comment thread
JisoLya marked this conversation as resolved.
public static HugeGraph graph() {
Assert.assertNotNull(graph);
//Assert.assertFalse(graph.closed());
Comment thread
JisoLya marked this conversation as resolved.
Outdated
if (graph == null) {
synchronized (CoreTestSuite.class){
if (graph == null) {
initEnv();
init();

@imbajin imbajin Jan 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‼️ Critical: Exception handling concern in lazy initialization

The initEnv() and init() methods can throw exceptions. If an exception occurs inside the synchronized block:

  1. graph remains null
  2. Subsequent calls will retry initialization (possibly desirable, but may cause repeated failures)

Consider whether failed initialization should be remembered to provide a clearer error message on subsequent calls, or at minimum document this behavior.

Also, there's an ordering dependency: initEnv() must complete before init(). While this works with the current registered flag, consider whether you need additional error handling if initEnv() succeeds but init() fails.

}
}
}
Comment thread
JisoLya marked this conversation as resolved.
return graph;
}

Expand Down
Loading