Skip to content

fix(pd): populate memberSize in GET / endpoint response #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imbajin merged 3 commits into from
Apr 21, 2026
Merged

fix(pd): populate memberSize in GET / endpoint response #3003

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc8e42b
fix(pd): set memberSize from RaftEngine members in IndexAPI
caglareker Apr 19, 2026
4db9735
fix(pd): complete GET / stats fix and add test coverage
imbajin Apr 20, 2026
839a3d2
fix(pd): relax storeSize assertion in PD-only test environment
imbajin Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hugegraph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/rest/IndexAPI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public BriefStatistics index() throws PDException, ExecutionException, Interrupt
BriefStatistics statistics = new BriefStatistics();
statistics.leader = RaftEngine.getInstance().getLeaderGrpcAddress();
statistics.state = pdService.getStoreNodeService().getClusterStats().getState().toString();
statistics.memberSize = RaftEngine.getInstance().getMembers().size();
statistics.storeSize = pdService.getStoreNodeService().getActiveStores().size();
statistics.graphSize = pdService.getPartitionService().getGraphs().size();

@imbajin imbajin Apr 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous fix adds:
statistics.memberSize = RaftEngine.getInstance().getMembers().size();

But the cluster() method (the "correct" counterpart) uses the service layer:

pdService.getMembers(Pdpb.GetMembersRequest.newBuilder().build(), response);
statistics.memberSize = pdList.size();  // from pdService, not RaftEngine

The issue discussion (comments 3–4 from bitflicker64 and dosubot) explicitly recommends using pdService.getMembers().size() for consistency with cluster() and to stay in the service layer. The merged fix goes against this recommendation.

statistics.partitionSize = pdService.getStoreNodeService().getShardGroups().size();
Expand Down
Loading