Skip to content

chore(docs): add contributing guide#1687

Merged
numinnex merged 2 commits intoapache:masterfrom
caicancai:doc
May 6, 2025
Merged

chore(docs): add contributing guide#1687
numinnex merged 2 commits intoapache:masterfrom
caicancai:doc

Conversation

@caicancai
Copy link
Copy Markdown
Member

@caicancai caicancai commented Apr 12, 2025

Learn from opendal's documentation and add contribution documentation to iggy

@caicancai caicancai changed the title feat(docs): add contributing guide chore(docs): add contributing guide Apr 12, 2025
@kparisa
Copy link
Copy Markdown
Contributor

kparisa commented Apr 15, 2025

@caicancai thanks for the PR. We should also add this to Iggy's website [iggy.apache.org]
Do you want to contribute there as well? https://github.com/apache/iggy-website

@caicancai
Copy link
Copy Markdown
Member Author

caicancai commented Apr 15, 2025

@caicancai thanks for the PR. We should also add this to Iggy's website [iggy.apache.org] Do you want to contribute there as well? https://github.com/apache/iggy-website

@hubcio @kparisa Thank you for your reply. If this PR is merged, I will update this document to the official website.

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
@caicancai caicancai requested a review from martin-g April 30, 2025 00:25
Comment thread CONTRIBUTING.md Outdated
@spetz
Copy link
Copy Markdown
Contributor

spetz commented Apr 30, 2025

Hey,
Thanks for the contribution, we need to verify why does the CI check fails, as it looks like some issue with resolving the origin.

@martin-g
Copy link
Copy Markdown
Member

martin-g commented Apr 30, 2025

Wild guess: most probably because the contributor forked just the master branch (this is the default Github behavior).

@caicancai
Copy link
Copy Markdown
Member Author

Hey, Thanks for the contribution, we need to verify why does the CI check fails, as it looks like some issue with resolving the origin.

Do you mind if I try to fix it?

@spetz
Copy link
Copy Markdown
Contributor

spetz commented Apr 30, 2025

Hey, Thanks for the contribution, we need to verify why does the CI check fails, as it looks like some issue with resolving the origin.

Do you mind if I try to fix it?

Feel free to do it :)

@caicancai
Copy link
Copy Markdown
Member Author

caicancai commented May 1, 2025

Wild guess: most probably because the contributor forked just the master branch (this is the default Github behavior).

@spetz @martin-g Your guess is correct, because the other PR #1712 did not fork the master branch, and its CI did not fail.

test https://github.com/caicancai/iggy/pull/1/checks

@martin-g
Copy link
Copy Markdown
Member

martin-g commented May 5, 2025

Your guess is correct

Thanks for confirming!
I have faced this issue in the past too!

https://github.com/apache/iggy/blob/master/.github/scripts/detect-changed-files.sh could be dropped in favor of action like https://github.com/Ana06/get-changed-files

@spetz
Copy link
Copy Markdown
Contributor

spetz commented May 5, 2025

I think it should work now thanks to #1738

spetz
spetz previously approved these changes May 6, 2025
spetz
spetz previously approved these changes May 6, 2025
hubcio
hubcio previously approved these changes May 6, 2025
Comment thread CONTRIBUTING.md Outdated
@caicancai caicancai dismissed stale reviews from hubcio and spetz via 77336af May 6, 2025 14:53
@numinnex numinnex merged commit 8174262 into apache:master May 6, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants