Skip to content

Commit

Permalink
Remove the import/no-internal-modules lint rule
Browse files Browse the repository at this point in the history
With Node.js adopting a standard for packages to declare their exports,
this rule may not be useful anymore. It should be legal to import any
valid export from a package.

An open [issue] on eslint-plugin-import tracks this ecosystem feature
and when that resolves there may be a better rule to enable.

[issue]: import-js/eslint-plugin-import#1868
  • Loading branch information
tilgovi committed Sep 20, 2020
1 parent f50583b commit 2de1a07
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
* under the License.
*/

const path = require('path');
const babel = require('@babel/core');

// Use the root babel.config.js for module resolution.
Expand All @@ -44,7 +43,6 @@ module.exports = {
'import/newline-after-import': 'error',
'import/no-absolute-path': 'error',
'import/no-default-export': 'error',
'import/no-internal-modules': 'error',
'import/order': [
'error',
{
Expand Down Expand Up @@ -141,12 +139,6 @@ module.exports = {
assert: true,
},
rules: {
'import/no-internal-modules': [
'error',
{
allow: [path.resolve(__dirname, './packages/*/src/**')],
},
],
'import/no-relative-parent-imports': 'off',
},
},
Expand Down

0 comments on commit 2de1a07

Please sign in to comment.