-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-7028][CH][Part-7] Support one pipeline write for mergetree #7788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Gluten Clickhouse CI |
968ca64
to
06d559f
Compare
Run Gluten Clickhouse CI |
06d559f
to
cd055cc
Compare
Run Gluten Clickhouse CI |
cd055cc
to
88e7262
Compare
Run Gluten Clickhouse CI |
88e7262
to
367d35d
Compare
Run Gluten Clickhouse CI on x86 |
367d35d
to
2d45aca
Compare
Run Gluten Clickhouse CI on x86 |
2d45aca
to
924aaec
Compare
Run Gluten Clickhouse CI on x86 |
924aaec
to
293b20c
Compare
Run Gluten Clickhouse CI on x86 |
1 similar comment
Run Gluten Clickhouse CI on x86 |
11 tasks
…ine builder instead of query plan, since query plan only contains read rel output header.
[Improve] Using callback to update config without copying config [Refactor] NativeExpressionEvaluator and refactor Java_org_apache_spark_sql_execution_datasources_CHDatasourceJniWrapper_createMergeTreeWriter [Refactor] Simplify the logic of evaluating tmp_path [Refactor] Remove Java_org_apache_gluten_vectorized_ExpressionEvaluatorJniWrapper_injectWriteFilesTempPath
2aff749
to
3277924
Compare
Run Gluten Clickhouse CI on x86 |
Run Gluten Clickhouse CI on x86 |
zzcclp
approved these changes
Nov 10, 2024
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR implements one pipeline write for mergetree:
ColumnBatch
is returned in pipeline write, we now passstring
instead ofMap
from C++ to java to avoid complex type, and we can utilize spark's utility to parse partition which is more compatibility.BasicWriteJobStatsTracker
to create `BasicWriteTaskStats. which compelete previous work.message write
, we now use it in the pipeline mode for both mergetree and files(parqet, orc).RutimeSettings
andRuntimeConfig
More details on
RutimeSettings
andRuntimeConfig
To avoid harded code in product code, We now start to define type safed
ConfigEntry[T]
for configuration and setting key, For example:will be changed to:
(Fixes: #7028)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)