Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-8313][VL] Enable json_array_length #8314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GLUTEN-8313][VL] Enable json_array_length #8314

wants to merge 1 commit into from
+2 −3

Conversation

WangGuangxin
Copy link
Contributor

What changes were proposed in this pull request?

Enable json_array_length

(Fixes: #8313)

How was this patch tested?

UT

@github-actions github-actions bot added the VELOX label Dec 24, 2024
@github-actions GitHub Actions
Copy link

#8313

@WangGuangxin
Copy link
Contributor Author

pending facebookincubator/velox#11946

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Dec 24, 2024 •
edited
Loading

@WangGuangxin, could you enable the functionality in this pr to see CI feedback in advance?
It requires changing the Velox branch to your own one with that velox patch applied.
https://github.com/apache/incubator-gluten/blob/main/ep/build-velox/src/get_velox.sh#L20

@github-actions github-actions bot added the BUILD label Dec 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Feb 8, 2025
@WangGuangxin WangGuangxin force-pushed the feat_json_array_length branch from 68083c5 to e949cca Compare February 8, 2025 02:10
@github-actions github-actions bot removed the stale stale label Feb 9, 2025
@WangGuangxin WangGuangxin force-pushed the feat_json_array_length branch from e949cca to 26c3e6f Compare February 28, 2025 11:08
@github-actions github-actions bot removed the BUILD label Feb 28, 2025
@WangGuangxin WangGuangxin marked this pull request as ready for review February 28, 2025 11:09
@WangGuangxin WangGuangxin force-pushed the feat_json_array_length branch 2 times, most recently from 5858b68 to ebb9bcf Compare March 4, 2025 15:19
@github-actions github-actions bot added the DOCS label Mar 4, 2025
@WangGuangxin WangGuangxin force-pushed the feat_json_array_length branch from ebb9bcf to c752709 Compare March 5, 2025 01:41
@WangGuangxin WangGuangxin requested a review from PHILO-HE March 5, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHILO-HE PHILO-HE Awaiting requested review from PHILO-HE

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DOCS VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VL] Enable json_array_length
2 participants
@WangGuangxin @PHILO-HE