Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[GLUTEN-5884][VL] change default load quantum to 8M for local… #8900

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Revert "[GLUTEN-5884][VL] change default load quantum to 8M for local… #8900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,10 +406,10 @@ object VeloxConfig {
val LOAD_QUANTUM =
buildStaticConf("spark.gluten.sql.columnar.backend.velox.loadQuantum")
.internal()
.doc("Set the load quantum for velox file scan, recommend to use the default value (8MB) " +
.doc("Set the load quantum for velox file scan, recommend to use the default value (256MB) " +
"for performance consideration. If Velox cache is enabled, it can be 8MB at most.")
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("8MB")
.createWithDefaultString("256MB")

val MAX_COALESCED_DISTANCE_BYTES =
buildStaticConf("spark.gluten.sql.columnar.backend.velox.maxCoalescedDistance")
Expand Down
2 changes: 1 addition & 1 deletion cpp/velox/compute/VeloxBackend.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ void VeloxBackend::initConnector() {
connectorConfMap[velox::connector::hive::HiveConfig::kPrefetchRowGroups] =
backendConf_->get<std::string>(kPrefetchRowGroups, "1");
connectorConfMap[velox::connector::hive::HiveConfig::kLoadQuantum] =
backendConf_->get<std::string>(kLoadQuantum, "8388608"); // 8M
backendConf_->get<std::string>(kLoadQuantum, "268435456"); // 256M
connectorConfMap[velox::connector::hive::HiveConfig::kFooterEstimatedSize] =
backendConf_->get<std::string>(kDirectorySizeGuess, "32768"); // 32K
connectorConfMap[velox::connector::hive::HiveConfig::kFilePreloadThreshold] =
Expand Down
Loading