NO_ISSUE: Copying resources directly to target instead to src/main/resources to keep module sources clean.
#3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
martinweiler
approved these changes
Oct 2, 2024
pefernan
force-pushed
the
no_issue_copy_resources_cleanup
branch
from
a80dba2
to
27724bb
Compare
pefernan
changed the title
target instead to src/main/resources to keep module sources clean.target instead to src/main/resources to keep module sources clean.
pefernan
commented
Oct 2, 2024
| @@ -73,7 +73,7 @@ public class DecisionCodegen extends AbstractGenerator { | |||
| public static final String GENERATOR_NAME = "decisions"; | |||
|
|
|||
| /** | |||
| * (boolean) generate java classes to support strongly typed input (default false) | |||
| * (boolean) generate java classes to support strongly typed input (default false) | |||
There was a problem hiding this comment.
@gitgabrio looks like one of your Pr's introduced this and was breaking the build :S
gitgabrio
reviewed
Oct 3, 2024
|
@pefernan |
…/resources` to keep module sources clean.
pefernan
force-pushed
the
no_issue_copy_resources_cleanup
branch
from
016188f
to
6a063d4
Compare
pefernan
changed the title
target instead to src/main/resources to keep module sources clean.target instead to src/main/resources to keep module sources clean.
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Oct 10, 2024
…/resources` to keep module sources clean. (apache#3691) * NO_ISSUE: Copying resources directly to `target` instead to `src/main/resources` to keep module sources clean. * - fix formatting * - renamed path variables * - format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a bad config we've been spreading around for some time, with this change we copy static resources directly to target, so they'll be bundled in the .jar but keeping the sources clean.
Ensemble:
#3691
apache/incubator-kie-kogito-apps#2106
Many thanks for submitting your Pull Request ❤️!
Closes/Fixes/Resolves #ISSUE-NUMBER
Description:
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject[0.9.x] Issue-XYZ SubjectHow to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.