bugfix:Fix the issues of empty rollback infinite retries and inability to resolve hanging bugs in TCC-Fence mode.#684
Closed
yangwenbinch wants to merge 7 commits intoapache:masterfrom
Closed
Conversation
Author
|
Which issue(s) this PR fixes: |
|
luky116
reviewed
Dec 21, 2024
| } | ||
| log.Infof("Insert tcc fence suspend record xid: %s, branchId: %d", xid, branchId) | ||
| return nil | ||
| return true, tx.Commit() |
Contributor
|
正在测试 |
Contributor
|
Whether the pr title or code comment, please do not use |
|
Contributor
|
@泽睿 |
Contributor
|
Please change the title of this PR in English. Maybe you can get help from ChatGPT. |
yangwenbinch
changed the title
Contributor
|
我觉得在QueryTCCFenceDO方法中将查不到数据时返回nil即可修复，请问这样修改是否可行？我在此pr上提交了该修改 #745 |
Author
功能上无影响，但如发生悬挂问题，会导致忽略报错无法插入悬挂记录，当commit请求先于prepare请求过来时，commit请求被忽略，prepare请求会插入记录，此记录只会等待最大超时时间才会被销毁。本人理解此处应确认错误后插入一条悬挂或空回滚记录，如prepare请求后至则直接放弃执行。 |
Contributor
|
fixed #745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
解决tcc-fence无限回滚与无法解决悬挂问题
具体问题见链接：apache/incubator-seata-go-samples#53
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
此问题使tcc-fence模式下使用问题较大
Does this PR introduce a user-facing change?: