Skip to content

optimize: merge channel availability log output and adjust log level #8203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shenshichao163-oss wants to merge 1 commit into
base: 2.x
Choose a base branch
from
+7 −3
Open

optimize: merge channel availability log output and adjust log level #8203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientChannelManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,17 +251,21 @@ void doReconnect(List<String> availList, String transactionServiceGroup) {
}
}
if (failedMap.size() > 0) {
// Merge all failed addresses into a single log entry to avoid flooding logs.
// info level: output summary without stack traces
if (LOGGER.isInfoEnabled()) {
LOGGER.error(
LOGGER.info(
"{} can not connect to {} cause:{}",
FrameworkErrorCode.NetConnect.getErrCode(),
failedMap.keySet(),
failedMap.values().stream()
.map(Throwable::getMessage)
.collect(Collectors.toSet()));
} else if (LOGGER.isDebugEnabled()) {
}
// debug level: output detailed stack traces for each failed address
if (LOGGER.isDebugEnabled()) {
failedMap.forEach((key, value) -> {
LOGGER.error(
LOGGER.debug(
"{} can not connect to {} cause:{} trace information:",
FrameworkErrorCode.NetConnect.getErrCode(),
key,
Expand Down