Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] feat(CI): Introducing surefire.rerunFailingTestsCount to identify Flakes tests. #1865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhengchenyu
Copy link
Collaborator

What changes were proposed in this pull request?

We can find many flaky test, it is not conducive to review code.

We can introduce surefire.rerunFailingTestsCount=2, the test is considered failed when it fails three times, or Flaskes.

@zhengchenyu
Copy link
Collaborator Author

@jerqi @zuston

Do you think we need to introduce rerunFailingTestsCount?

Copy link

github-actions bot commented Jul 5, 2024

Test Results

 2 657 files  +10   2 657 suites  +10   5h 30m 24s ⏱️ + 3m 50s
   946 tests ± 0     945 ✅ + 1   1 💤 ±0  0 ❌ ±0 
11 799 runs  +10  11 784 ✅ +11  15 💤 ±0  0 ❌ ±0 

Results for commit 4c5a174. ± Comparison against base commit 7049569.

@rickyma
Copy link
Contributor

rickyma commented Jul 9, 2024

This will cause issues to be hidden. We need to find out the flaky tests and fix them. This is what UTs should do.

@zhengchenyu
Copy link
Collaborator Author

@rickyma

In fact, flaky test will not be hidden, they will show in logs. Here are hadoop test log:

[WARNING] Flakes: 
[WARNING] org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks.testSetRepIncWithUnderReplicatedBlocks(org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks)
[ERROR]   Run 1: TestUnderReplicatedBlocks.testSetRepIncWithUnderReplicatedBlocks:80 » TestTimedOut
[INFO]   Run 2: PASS

For now, when the some test failed, we will manually confirm whether it is flaky. If it is flaky, we still merged to master.
I'm afraid that some serious errors may be mistaken for flaky due to human negligence.

@rickyma
Copy link
Contributor

rickyma commented Jul 11, 2024

If all the tests finally pass, who will still check the logs and look for the flaky tests? I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants