Add user in heartbeat of RssShuffleManager #1876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
reviewed
Jul 11, 2024
| // compatible with lower version clients | ||
| if (user == null) { |
There was a problem hiding this comment.
How to handle the case user == null? Because there may be existing legacy clients.
There was a problem hiding this comment.
How to handle the case
user == null? Because there may be existing legacy clients.
When the user field is not specified in legacy clients, the value will be empty instead of null. So if coordinator restarts, it actually calls registerApplicationInfo(appId, "").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add user in AppHeartBeatRequest
Why are the changes needed?
if Coordinator restarts, the RssShuffleManager will not reregister, and user will be lost in heartbeat.
Fix: #1875
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Exsiting UTs.