[#2030] fix(client-spark): Remove javax and logging from relocation list to solve NoClassDefFoundError #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 760 files - 32 2 760 suites - 32 5h 38m 7s ⏱️ - 12m 10s For more details on these failures, see this check. Results for commit 25576f6. ± Comparison against base commit 3673b55. ♻️ This comment has been updated with latest results. |
maobaolong
changed the title
maobaolong
force-pushed
the
fixShadedClient
branch
from
5ed905e to
807e2cf
Compare
maobaolong
changed the title
maobaolong
force-pushed
the
fixShadedClient
branch
from
807e2cf to
ef5b630
Compare
|
Could you help review this? @zhengchenyu |
|
@jerqi Please help to review this PR, thanks! |
|
@jerqi thanks for your review |
maobaolong
added a commit
to maobaolong/incubator-uniffle
that referenced
this pull request
Nov 4, 2024
…tion list to solve NoClassDefFoundError (apache#2029) ### What changes were proposed in this pull request? Do not relocate javax to avoid NoClassDefFoundError issue. ### Why are the changes needed? Fix: apache#2030 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Thanks for the verify check by @zhengchenyu . This is not reproduced on my env. (cherry picked from commit 95537cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not relocate javax to avoid NoClassDefFoundError issue.
Why are the changes needed?
Fix: #2030
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Thanks for the verify check by @zhengchenyu . This is not reproduced on my env.