Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2269] refactor: Fix duplicated blockIds issue caused by duplicated reportShuffleResult #2270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maobaolong
Copy link
Member

What changes were proposed in this pull request?

Client stop retrying and throw RssException for reportShuffleResult operation while interrupted by caller.

Why are the changes needed?

Fix: #2269

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.76%. Comparing base (ac89c19) to head (1594be3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ffle/client/impl/grpc/ShuffleServerGrpcClient.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2270      +/-   ##
============================================
- Coverage     51.78%   51.76%   -0.03%     
+ Complexity     2966     2965       -1     
============================================
  Files           479      479              
  Lines         22566    22569       +3     
  Branches       2068     2069       +1     
============================================
- Hits          11686    11683       -3     
- Misses        10140    10149       +9     
+ Partials        740      737       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 2, 2024

Test Results

 2 352 files   -   614   2 352 suites   - 614   2h 19m 2s ⏱️ - 4h 8m 18s
   930 tests  -   166     930 ✅  -   164  0 💤  -  2  0 ❌ ±0 
11 886 runs   - 1 849  11 886 ✅  - 1 819  0 💤  - 30  0 ❌ ±0 

Results for commit 1594be3. ± Comparison against base commit db611f4.

This pull request removes 166 tests.
org.apache.uniffle.test.AQERepartitionTest ‑ resultCompareTest
org.apache.uniffle.test.AQESkewedJoinTest ‑ resultCompareTest
org.apache.uniffle.test.AQESkewedJoinWithLocalOrderTest ‑ resultCompareTest
org.apache.uniffle.test.AccessCandidatesCheckerKerberizedHadoopTest ‑ test
org.apache.uniffle.test.AccessClusterTest ‑ org.apache.uniffle.test.AccessClusterTest
org.apache.uniffle.test.AssignmentWithTagsTest ‑ testTags
org.apache.uniffle.test.AutoAccessTest ‑ test
org.apache.uniffle.test.CombineByKeyTest ‑ combineByKeyTest
org.apache.uniffle.test.ContinuousSelectPartitionStrategyTest ‑ resultCompareTest
org.apache.uniffle.test.CoordinatorAdminServiceTest ‑ test
…

♻️ This comment has been updated with latest results.

@@ -797,6 +798,11 @@ private ReportShuffleResultResponse doReportShuffleResult(ReportShuffleResultReq
try {
ReportShuffleResultResponse response = getBlockingStub().reportShuffleResult(rpcRequest);
return response;
} catch (StatusRuntimeException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reuse RetryUtils?

@jerqi jerqi changed the title [#2269] Fix duplicated blockIds issue caused by duplicated reportShuffleResult [#2269] refactor: Fix duplicated blockIds issue caused by duplicated reportShuffleResult Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Client do not honor CANCEL interrupt exception while reportShuffleResult cause duplicated blockIds
3 participants