[#2279] improvement(spark): Trigger the upstream rewrite when the read stage fails #2280
+59
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 509 files - 457 2 509 suites - 457 3h 49m 2s ⏱️ - 2h 39m 46s Results for commit 5fbee9a. ± Comparison against base commit 4ce1aa8. This pull request removes 182 tests. |
|
Could you add a ut for this? |
jerqi
reviewed
Dec 9, 2024
| } | ||
| }); | ||
| } | ||
|
|
||
| public void setClearedMapTrackerBlock(boolean isCleared) { |
There was a problem hiding this comment.
Could you give a better name for this?
zuston
changed the title
zuston
reviewed
Dec 9, 2024
| code = RssProtos.StatusCode.SUCCESS; | ||
| status.incPartitionFetchFailure(stageAttempt, partitionId); | ||
| int fetchFailureNum = status.getPartitionFetchFailureNum(stageAttempt, partitionId); | ||
| if (fetchFailureNum >= shuffleManager.getMaxFetchFailures()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the current Reader fails to obtain Shuffle data, it does not trigger the upstream Stage to rewrite the data. If a Shuffle Server fails, it does not trigger Stage retry.
Why are the changes needed?
Fix: #2279
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.