Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR] test: Fix ConcurrentModifiedException while use TestAppender #2286

Conversation

maobaolong
Copy link
Member

What changes were proposed in this pull request?

Fix ConcurrentModifiedException while use TestAppender

Why are the changes needed?

[ERROR] testNewAppWhileCheckLeak{ExtensionContext}  Time elapsed: 0.3 s  <<< ERROR!
java.util.ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:911)
    at java.util.ArrayList$Itr.next(ArrayList.java:861)
    at org.apache.uniffle.common.log.TestLoggerExtension$TestAppender.wasLogged(TestLoggerExtension.java:106)
    at org.apache.uniffle.common.log.TestLoggerExtension.wasLogged(TestLoggerExtension.java:73)
    at org.apache.uniffle.server.storage.LocalStorageManagerTest.testNewAppWhileCheckLeak(LocalStorageManagerTest.java:399)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.77%. Comparing base (28dc8a2) to head (e525ae9).
Report is 1 commits behind head on branch-0.10.

Additional details and impacted files
@@                Coverage Diff                @@
##             branch-0.10    #2286      +/-   ##
=================================================
- Coverage          51.96%   51.77%   -0.19%     
+ Complexity          3357     2966     -391     
=================================================
  Files                529      479      -50     
  Lines              29930    22566    -7364     
  Branches            2580     2068     -512     
=================================================
- Hits               15552    11684    -3868     
+ Misses             13366    10146    -3220     
+ Partials            1012      736     -276     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

 2 965 files  + 63   2 965 suites  +63   6h 27m 36s ⏱️ + 20m 8s
 1 096 tests ±  0   1 093 ✅ ±  0   2 💤 ±0  1 ❌ ±0 
13 734 runs  +123  13 703 ✅ +124  30 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit e525ae9. ± Comparison against base commit 9a9bc7c.

@jerqi
Copy link
Contributor

jerqi commented Dec 11, 2024

You can commit this to branch-0.10 directly. You don't need to raise a pull request.

@maobaolong
Copy link
Member Author

@jerqi Oh, i see

@maobaolong maobaolong closed this Dec 11, 2024
@maobaolong
Copy link
Member Author

@jerqi Thanks for your tip, I cherry-picked this commit to the branch-0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants