Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2288] feat(dashboard): Show nodeInfo in excludeNode page #2289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kuszz
Copy link
Contributor

@kuszz kuszz commented Dec 12, 2024

What changes were proposed in this pull request?

Show nodeInfo in excludeNode page
image

Why are the changes needed?

Fix: #2288

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Copy link

Test Results

 2 934 files   - 32   2 934 suites   - 32   6h 13m 37s ⏱️ - 20m 24s
 1 096 tests ± 0   1 093 ✅  -  1   2 💤 ±0  0 ❌ ±0  1 🔥 +1 
13 673 runs   - 62  13 642 ✅  - 63  30 💤 ±0  0 ❌ ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 4b5f339. ± Comparison against base commit b7c9ca5.

@jerqi
Copy link
Contributor

jerqi commented Dec 12, 2024

@yl09099 Could you help review this pull request?

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yl09099
Copy link
Contributor

yl09099 commented Dec 13, 2024

Why is your image above in the active option with add and delete buttons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add node info in excludeNode page, remove ExcludeNodeList.vue
3 participants