Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2300][Bug] Long tail tasks in the Write Stage retry phase results in data loss. #2301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[#2300][Bug] Long tail tasks in the Write Stage retry phase results in data loss. #2301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...rk/common/src/main/java/org/apache/uniffle/shuffle/manager/ShuffleManagerGrpcService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ public void reportShuffleWriteFailure(
// Clear the metadata of the completed task, otherwise some of the stage's data will
// be lost.
shuffleManager.unregisterAllMapOutput(shuffleId);
// Need to clear the mapStatus twice to prevent partition data loss due to the
// long-tail task performed before the stage retry.
shuffleManager.unregisterAllMapOutput(shuffleId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work? Just invoking twice in the same time point.

// Deregister the shuffleId corresponding to the Shuffle Server.
shuffleManager.getShuffleWriteClient().unregisterShuffle(appId, shuffleId);
shuffleServerWriterFailureRecord.setClearedMapTrackerBlock(true);
Expand Down
Loading