Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2376] test(coordinator): The interval of SimpleClusterManager.nodesCheck should be bigger than that of org.awaitility.Awaitility.await #2377

Merged
merged 1 commit into from
Mar 5, 2025
Merged

[#2376] test(coordinator): The interval of SimpleClusterManager.nodesCheck should be bigger than that of org.awaitility.Awaitility.await #2377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions coordinator/src/test/java/org/apache/uniffle/coordinator/SimpleClusterManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public void getServerListTest() throws Exception {
public void getLostServerListTest() throws Exception {
CoordinatorConf coordinatorConf = new CoordinatorConf();
// Shorten the heartbeat time
coordinatorConf.setLong(CoordinatorConf.COORDINATOR_HEARTBEAT_TIMEOUT, 300L);
coordinatorConf.setLong(CoordinatorConf.COORDINATOR_HEARTBEAT_TIMEOUT, 600L);
try (SimpleClusterManager clusterManager =
new SimpleClusterManager(coordinatorConf, new Configuration())) {
ServerNode sn1 = new ServerNode("sn1", "ip", 0, 100L, 50L, 20, 10, grpcTags);
Expand Down Expand Up @@ -174,7 +174,7 @@ public void getLostServerListTest() throws Exception {
public void getUnhealthyServerList() throws Exception {
CoordinatorConf coordinatorConf = new CoordinatorConf();
// Shorten the heartbeat time
coordinatorConf.setLong(CoordinatorConf.COORDINATOR_HEARTBEAT_TIMEOUT, 300L);
coordinatorConf.setLong(CoordinatorConf.COORDINATOR_HEARTBEAT_TIMEOUT, 600L);
try (SimpleClusterManager clusterManager =
new SimpleClusterManager(coordinatorConf, new Configuration())) {
ServerNode sn1 = new ServerNode("sn1", "ip", 0, 100L, 50L, 20, 10, grpcTags);
Expand Down Expand Up @@ -375,7 +375,7 @@ private void addNode(String id, SimpleClusterManager clusterManager) {
@Test
public void heartbeatTimeoutTest() throws Exception {
CoordinatorConf ssc = new CoordinatorConf();
ssc.setLong(CoordinatorConf.COORDINATOR_HEARTBEAT_TIMEOUT, 300L);
ssc.setLong(CoordinatorConf.COORDINATOR_HEARTBEAT_TIMEOUT, 600L);
try (SimpleClusterManager clusterManager = new SimpleClusterManager(ssc, new Configuration())) {
addNode("sn0", clusterManager);
addNode("sn1", clusterManager);
Expand Down
Loading