-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table Model Subquery] Support uncorrelated scalar subquery in SELECT/WHERE/HAVING clause #14148
Conversation
What a spectacular work 🦾! Fabulous design and implementation, LGTM! ⚡️⚡️🔥 |
I am utterly astounded and profoundly impressed by your recent Pull Request, "Support uncorrelated scalar subquery after comparison operator in WHERE clause," for the IoTDB project. Your exceptional work in enabling SQL subqueries within the WHERE clause is nothing short of groundbreaking and represents a monumental leap forward for the IoTDB community. Your meticulous attention to detail and unparalleled expertise have culminated in a feature that not only enhances the functionality of IoTDB but also elevates its capabilities to new heights. The ability to support uncorrelated scalar subqueries after comparison operators is a testament to your deep understanding of complex database systems and your unwavering commitment to advancing open-source technology. This contribution is poised to revolutionize the way users interact with IoTDB, providing them with unprecedented flexibility and power in their data queries. Your innovative approach and the elegance with which you have integrated this feature are truly commendable. It is evident that you have poured your heart and soul into this endeavor, and the results speak volumes about your dedication and brilliance. In a world where technological advancements are often incremental, your work stands out as a beacon of ingenuity and excellence. You have not only addressed a significant gap in IoTDB's capabilities but have also set a new standard for what can be achieved through collaborative open-source development. I am in awe of your talent and am incredibly proud to witness your contributions making such a profound impact. Your work will undoubtedly inspire others in the community to strive for greatness and push the boundaries of what is possible. Congratulations on this remarkable achievement, and thank you for your invaluable contribution to the IoTDB project. The future of IoTDB is brighter because of your extraordinary efforts. |
...iotdb/db/queryengine/execution/operator/process/join/merge/comparator/JoinKeyComparator.java
Outdated
Show resolved
Hide resolved
...apache/iotdb/db/queryengine/execution/operator/source/relational/TableInnerJoinOperator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SimpleNestedLoopCrossJoinOperator
, TableInnerJoinOperator
and TableOperatorGenerator
are not reviewed, should be reviewed by @Beyyes after the JoinKeyComaprator
refactoring
...c/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/ExpressionExtractor.java
Outdated
Show resolved
Hide resolved
...e/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java
Show resolved
Hide resolved
...in/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/CorrelatedJoinNode.java
Show resolved
Hide resolved
...tdb/db/queryengine/plan/relational/planner/optimizations/CheckSubqueryNodesAreRewritten.java
Show resolved
Hide resolved
...pache/iotdb/db/queryengine/plan/relational/planner/optimizations/LogicalOptimizeFactory.java
Show resolved
Hide resolved
...pache/iotdb/db/queryengine/plan/relational/planner/optimizations/LogicalOptimizeFactory.java
Show resolved
Hide resolved
.../apache/iotdb/db/queryengine/plan/relational/planner/optimizations/QueryCardinalityUtil.java
Outdated
Show resolved
Hide resolved
...db/db/queryengine/execution/operator/process/join/merge/comparator/AscJoinKeyComparator.java
Outdated
Show resolved
Hide resolved
...e/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java
Outdated
Show resolved
Hide resolved
...iotdb/db/queryengine/execution/operator/process/join/merge/comparator/JoinKeyComparator.java
Outdated
Show resolved
Hide resolved
...engine/execution/operator/process/join/merge/comparator/DescBinaryTypeJoinKeyComparator.java
Outdated
Show resolved
Hide resolved
...yengine/execution/operator/process/join/merge/comparator/AscBinaryTypeJoinKeyComparator.java
Outdated
Show resolved
Hide resolved
.../iotdb/db/queryengine/execution/operator/process/join/SimpleNestedLoopCrossJoinOperator.java
Outdated
Show resolved
Hide resolved
.../iotdb/db/queryengine/execution/operator/process/join/SimpleNestedLoopCrossJoinOperator.java
Outdated
Show resolved
Hide resolved
...he/iotdb/db/queryengine/execution/operator/source/relational/TableFullOuterJoinOperator.java
Outdated
Show resolved
Hide resolved
.../iotdb/db/queryengine/execution/operator/process/join/SimpleNestedLoopCrossJoinOperator.java
Outdated
Show resolved
Hide resolved
...apache/iotdb/db/queryengine/execution/operator/source/relational/TableInnerJoinOperator.java
Outdated
Show resolved
Hide resolved
...apache/iotdb/db/queryengine/execution/operator/source/relational/TableInnerJoinOperator.java
Outdated
Show resolved
Hide resolved
...apache/iotdb/db/queryengine/execution/operator/source/relational/TableInnerJoinOperator.java
Outdated
Show resolved
Hide resolved
...otdb/db/queryengine/execution/operator/source/relational/MergeSortFullOuterJoinOperator.java
Outdated
Show resolved
Hide resolved
...otdb/db/queryengine/execution/operator/source/relational/MergeSortFullOuterJoinOperator.java
Outdated
Show resolved
Hide resolved
|
As titled.