Skip to content

Conversation

CRZbulabula
Copy link
Contributor

@CRZbulabula CRZbulabula commented Sep 20, 2025

To unify the audit feature, we define IAuditEntity in this PR, which provides all crucial fields for an audit log. To integrate audit into authentication feature, we implement the IAuditEntity for MPPQueryContext, passing it through the authentication codes.

Since we suppose to make the audit log feature as a native integration to IoTDB, we create a _internal_auditor user when the audit log is enabled.

@CRZbulabula CRZbulabula force-pushed the trigger-audit-log-v1 branch 4 times, most recently from d4a45cb to d8304a9 Compare September 21, 2025 08:53
@CRZbulabula CRZbulabula changed the title Append authentication audit logs for table modle Insert SQL authentication audit logs for table model Sep 21, 2025
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 14.24581% with 614 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.69%. Comparing base (205e373) to head (9bb8fbc).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...lan/relational/security/ITableAuthCheckerImpl.java 0.62% 160 Missing ⚠️
.../plan/execution/config/TableConfigTaskVisitor.java 3.44% 84 Missing ⚠️
...ne/plan/relational/security/AccessControlImpl.java 7.50% 37 Missing ⚠️
...ional/InformationSchemaContentSupplierFactory.java 0.00% 36 Missing ⚠️
...an/relational/security/TreeAccessCheckVisitor.java 0.00% 26 Missing ⚠️
...ava/org/apache/iotdb/commons/audit/UserEntity.java 24.24% 25 Missing ⚠️
...ache/iotdb/commons/auth/user/BasicUserManager.java 27.27% 24 Missing ⚠️
...e/iotdb/db/queryengine/common/MPPQueryContext.java 0.00% 19 Missing ⚠️
...ne/plan/relational/analyzer/StatementAnalyzer.java 38.46% 16 Missing ⚠️
...ache/iotdb/db/protocol/session/SessionManager.java 11.76% 15 Missing ⚠️
... and 46 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16450      +/-   ##
============================================
- Coverage     38.72%   38.69%   -0.04%     
  Complexity      207      207              
============================================
  Files          4933     4934       +1     
  Lines        325130   325576     +446     
  Branches      41338    41369      +31     
============================================
+ Hits         125902   125973      +71     
- Misses       199228   199603     +375     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.2% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@CRZbulabula CRZbulabula merged commit 25427da into master Sep 22, 2025
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant