fix: NodeValue.makeNodeFloat(String) datatype XSDfloat

test: TestNodeValue.float4 makeNodeFloat(String) is Float
apache · Mar 27, 2024 · 4fb3ce2 · 4fb3ce2
1 parent ab3daca
commit 4fb3ce2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java b/jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java
@@ -319,7 +319,7 @@ public static NodeValue makeNodeFloat(float f)
 
     public static NodeValue makeNodeFloat(String lexicalForm)
     {
-        NodeValue nv = makeNode(lexicalForm, null, XSDdouble.getURI()) ;
+        NodeValue nv = makeNode(lexicalForm, null, XSDfloat.getURI()) ;
         return nv ;
     }
 

diff --git a/jena-arq/src/test/java/org/apache/jena/sparql/expr/TestNodeValue.java b/jena-arq/src/test/java/org/apache/jena/sparql/expr/TestNodeValue.java
@@ -104,6 +104,14 @@ public void testFloat3() {
         assertTrue("Not same float: " + v1 + " & " + v2, v1.getFloat() == v2.getFloat());
         assertTrue("Not same float as double: " + v1 + " & " + v2, v1.getDouble() == v2.getDouble());
     }
+
+    @Test
+    public void testFloat4() {
+        NodeValue v1 = NodeValue.makeNodeFloat("5.7");
+        NodeValue v2 = NodeValue.makeFloat(5.7f);
+        assertTrue("Not same float: " + v1 + " & " + v2, v1.getFloat() == v2.getFloat());
+        assertTrue("Not same float as double: " + v1 + " & " + v2, v1.getDouble() == v2.getDouble());
+    }
 
     @Test
     public void testDouble1() {